Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isinstance/issubclass check #36

Merged
merged 2 commits into from
Jan 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions test/test_constantdict.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,3 +325,36 @@ def test_value_covariant() -> None:
_bar4: constantdict[str, str | int] = constantdict.fromkeys(["a", "b"], 42)
_bar5: constantdict[str, None] = constantdict.fromkeys(["a", "b"])
_bar6: constantdict[str, str | None] = constantdict.fromkeys(["a", "b"])


@pytest.mark.xfail(reason="types do not differentiate from dict (see #35)", strict=True)
def test_type_dict() -> None:
from collections.abc import Mapping as abc_Mapping
from collections.abc import MutableMapping as abc_MutableMapping
from typing import Mapping, MutableMapping
cd: constantdict[str, int] = constantdict(a=1, b=2)

assert isinstance(cd, constantdict)
assert not isinstance(cd, dict)

assert isinstance(cd, Mapping)
assert not isinstance(cd, MutableMapping)

assert isinstance(cd, abc_Mapping)
assert not isinstance(cd, abc_MutableMapping)


@pytest.mark.xfail(
reason="subclasses do not differentiate from dict (see #35)", strict=True)
def test_subclass_dict() -> None:
from collections.abc import Mapping as abc_Mapping
from collections.abc import MutableMapping as abc_MutableMapping
from typing import Mapping, MutableMapping

assert not issubclass(constantdict, dict)

assert issubclass(constantdict, Mapping)
assert not issubclass(constantdict, MutableMapping)

assert issubclass(constantdict, abc_Mapping)
assert not issubclass(constantdict, abc_MutableMapping)
Loading