Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change pop to indexing to get list element #203 #204

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

aspyk
Copy link
Contributor

@aspyk aspyk commented Oct 10, 2023

No description provided.

@mattijn
Copy link
Owner

mattijn commented Oct 11, 2023

Thanks for the PR @aspyk! I used this PR to as guineapig to test if I can insert a benchmark report. Apparently I only can run this successful on branches within the target repository.
I've tested your suggested changes locally and all seems fine! Thanks again for making this PR!

@mattijn mattijn merged commit a6f9dc4 into mattijn:main Oct 11, 2023
10 of 11 checks passed
@aspyk
Copy link
Contributor Author

aspyk commented Oct 12, 2023

You're welcome ! Thank you for making this lib available ;)
I've seen other threads on performance enhancement, I might take a look at them more or less soon too :)

@mattijn
Copy link
Owner

mattijn commented Oct 12, 2023

That would be great! If you need any help with this please let me know and I can try to assist👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants