Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run tests also on python 3.11 #212

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

theroggy
Copy link
Contributor

@theroggy theroggy commented Oct 20, 2023

  • It seems a bit too soon for python 3.12: shapely/geos doesn't seem ready yet
  • Python 3.11 in combination with shapely < 2.0 gives issues: when the github action tries to replace shapely 2.0 by 1.8.x, this fails

@theroggy theroggy changed the title CI: Run tests also on python 3.11 and 3.12 CI: Run tests also on python 3.11 Oct 20, 2023
@mattijn
Copy link
Owner

mattijn commented Oct 20, 2023

Thanks for this PR @theroggy! What do you mean with:

Python 3.11 in combination with shapely < 2.0 gives issues

Is there something missing on the topojson side?

@theroggy
Copy link
Contributor Author

theroggy commented Oct 20, 2023

Thanks for this PR @theroggy! What do you mean with:

Python 3.11 in combination with shapely < 2.0 gives issues

Is there something missing on the topojson side?

No, the step in the github action to downgrade shapely 2.0 (this is installed by default first due to being a dependency of topojson) to 1.8.x fails...

Check out the error here: https://github.com/mattijn/topojson/actions/runs/6588019199/job/17899425538

@mattijn
Copy link
Owner

mattijn commented Oct 20, 2023

Thanks for the PR, I modified the workflow slightly to install shapely first and then install other dependencies. I currently only test against shapely 1.8.5 for the 1.8.x series (thus not 1.8.0 and 1.8.4 anymore) since it also include builds for python 3.11. Now all tests are successful. Thanks again!

@mattijn mattijn merged commit 6e5eb76 into mattijn:main Oct 20, 2023
10 checks passed
@theroggy theroggy deleted the CI-add-tests-on-python-3.11-and-3.12 branch October 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants