Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.yml #218

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Update test.yml #218

merged 6 commits into from
Feb 7, 2024

Conversation

mattijn
Copy link
Owner

@mattijn mattijn commented Feb 7, 2024

Tests includes run on python 3.8, 3.10 and 3.12

Edit:
The current strategy is as follows:

strategy:
  matrix:
    python-version: ["3.8", "3.10", "3.12"]
    shapely-version: ["1.8", "2.0"]
    exclude:
      - python-version: "3.12"
        shapely-version: "1.8"

I cannot find a pre-build shapely 1.8 package for python version 3.12

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Benchmark result

benchmark
These PR changes are benchmarked against three files, compared with PyPi's latest release and the repository's main branch.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Benchmark result

benchmark
These PR changes are benchmarked against three files, compared with PyPi's latest release and the repository's main branch.

@mattijn
Copy link
Owner Author

mattijn commented Feb 7, 2024

Warnings from CI

topojson/core/join.py:132:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
topojson/core/join.py:158:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
topojson/core/topology.py:476:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
topojson/core/topology.py:520:24: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
topojson/core/topology.py:526:24: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
topojson/core/topology.py:605:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
topojson/core/topology.py:615:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`

And

tests/test_extract.py: 13 warnings
  /home/runner/work/topojson/topojson/topojson/core/extract.py:454: FionaDeprecationWarning: instances of this class -- CRS, geometry, and feature objects -- will become immutable in fiona version 2.0
    feature["type"] = feature["geometry"]["type"]

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Benchmark result

benchmark
These PR changes are benchmarked against three files, compared with PyPi's latest release and the repository's main branch.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Benchmark result

benchmark
These PR changes are benchmarked against three files, compared with PyPi's latest release and the repository's main branch.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Benchmark result

benchmark
These PR changes are benchmarked against three files, compared with PyPi's latest release and the repository's main branch.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Benchmark result

benchmark
These PR changes are benchmarked against three files, compared with PyPi's latest release and the repository's main branch.

@mattijn mattijn merged commit 8504712 into main Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant