Geojson ids option #220
Merged
Geojson ids option #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "id" doesn't exist then the original feature_{index} applies.
If they were then the data dict will have overwritten the previous feature rather than adding a new feature and its length will be shorter than the original length of the features. Not sure about raising error or just warning.
added description of param to Topology docstring
ignore_index being true will go to the default index likewie if the feature has no id it will use the default index
… is raised if duplicates ids exist.
…eature collection
mattijn
approved these changes
May 6, 2024
There was a problem hiding this comment.
Thank you @Mr-Ixolate! This PR is in excellent condition, awesome!
Thank you for adding the extra tests, all remaining tests are happy too. Merging!
(FYI, I will release a new version within a week or two)
Hlmt7
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #219
Change makes it so that
geojson.FeatureCollectionswith Features that have ids will have those ids passed through to the output of Topology.A new option
ignore_indexthat allows that behavior to be reverted to what it was before also added. Left off by defaultAdded three tests.
Two tests that counted the number of options were modified to increase the expected count by one.