fix: use node inspect to handle object types when running reporter #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3f06cfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
100%, I had this idea before but forgot to note it down. Great minds! |
|
@dschlabach Will get the paths working 👍 #29 |
mattpocock
approved these changes
Dec 7, 2024
|
Merging despite CI, will debug CI on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mattpocock - curious if this is something that you'd like to support with evalite. I am going to be doing a lot of testing on structured data and I noticed that when running the reporter, it's not printing out the objects as expected.
Before:
After
P.S. - Also, curious if there's a way to specify globs - I noticed there's a subcommand with
<glob>but I haven't been able to get path filtering working. Is that supported today? Was wanting to run evals for just 1 file so that I could see the report table.