Merge pull request #301 from mattpolzin/bugfix/300/explode-the-header

fix bug where headers were not allowed to define explode when decoding
mattpolzin · Aug 26, 2023 · 0f712cc · 0f712cc
2 parents e9c50c9 + adcc199
commit 0f712cc
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 0 deletions.
diff --git a/Sources/OpenAPIKit/Header/Header.swift b/Sources/OpenAPIKit/Header/Header.swift
@@ -170,6 +170,7 @@ extension OpenAPI.Header {
 
         // the following are parsed as part of Schema
         case style
+        case explode
         case allowReserved
         case example
         case examples
@@ -184,6 +185,7 @@ extension OpenAPI.Header {
                 .content,
                 .schema,
                 .style,
+                .explode,
                 .allowReserved,
                 .example,
                 .examples
@@ -208,6 +210,8 @@ extension OpenAPI.Header {
                 self = .schema
             case "style":
                 self = .style
+            case "explode":
+                self = .explode
             case "allowReserved":
                 self = .allowReserved
             case "example":
@@ -233,6 +237,8 @@ extension OpenAPI.Header {
                 return "schema"
             case .style:
                 return "style"
+            case .explode:
+                return "explode"
             case .allowReserved:
                 return "allowReserved"
             case .example:

diff --git a/Tests/OpenAPIKitTests/Header/HeaderTests.swift b/Tests/OpenAPIKitTests/Header/HeaderTests.swift
@@ -511,6 +511,67 @@ extension HeaderTests {
         )
     }
 
+    func test_header_withStyleAndExplode_encode() throws {
+        let header = OpenAPI.Header(
+            schema: .init(
+                .array(items: .string),
+                style: .form,
+                explode: false
+            ),
+            required: true
+        )
+
+        let encodedHeader = try orderUnstableTestStringFromEncoding(of: header)
+
+        assertJSONEquivalent(
+            encodedHeader,
+            """
+            {
+              "explode" : false,
+              "required" : true,
+              "schema" : {
+                "items" : {
+                  "type" : "string"
+                },
+                "type" : "array"
+              },
+              "style" : "form"
+            }
+            """
+        )
+    }
+
+    func test_header_withStyleAndExplode_decode() throws {
+        let headerData =
+        """
+        {
+          "explode" : false,
+          "required" : true,
+          "schema" : {
+            "items" : {
+              "type" : "string"
+            },
+            "type" : "array"
+          },
+          "style" : "form"
+        }
+        """.data(using: .utf8)!
+
+        let header = try orderUnstableDecode(OpenAPI.Header.self, from: headerData)
+
+        XCTAssertEqual(
+            header,
+            OpenAPI.Header(
+                schema: .init(
+                    .array(items: .string),
+                    style: .form,
+                    explode: false
+                ),
+                required: true
+            )
+        )
+    }
+
     func test_header_errorForBothContentAndSchema_decode() {
         let headerData =
         """