Minor fix for tika validation. #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a CLI script for testing tika too.
dmitriim
reviewed
Jul 24, 2023
|
|
||
| Options: | ||
| -h, --help Print out this help | ||
| -t, --testfileid (Optional) PDF or accepted file id to send to tika for analysis |
There was a problem hiding this comment.
Where do we get testfileid from? Is it id from mdl_files? If so, then this is not user friendly. Maybe we can pass a path to a test file instead? Or we could use files from tests/fixtures?
dmitriim
reviewed
Jul 24, 2023
| // along with Moodle. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| /** | ||
| * CLI config tester |
There was a problem hiding this comment.
Have you considered move this CLI to UI instead? E.g. after submitting setting we could check if it actually works and then display results?
|
Thanks @dvdcastro for submitting the patch. Bug fix looks good, however, I'm a bit hesitant about a new CLI script. I'd suggest to move this check to UI. If it's not something that you can do in a near future we can split bugfix and a new check as different PR so the bugfix could land faster. |
|
I merged fixing part of this PR here #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a CLI script for testing tika too.