[#61] Notify video is not embeddable #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ths controller is in charge of coordinating the state of the form depending on the interactions with the Player Stimulus Controller. - Update the YoutubePlayer class to account for load errors by taking a callback as a new parameter - Update the Dummy Player to account for load errors. They are triggered by the presence of a data attribute called error and matched on the name of the error we want to simulate. For now only load errors. The data attribute must exist -before- the load method is called on the dummy player. - Update player controller to trigger events on video load/failure - Lesson controller disables all other elements but the video link field if the video failed to load. Overriding its value with an url that ends in a succesful video load enables all the fields and the submit button - Add e2e test
mauriciofierrom
force-pushed
the
61-notify-video-not-embeddable
branch
from
bf79699 to
6e49131
Compare
Oh the flakines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
On Lesson creation, disable the form if the video fails to load and show an informative error message.