Fix RST syntax errors #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we should use namespaces for all classes and reference them using the full namespace
|
damn, sphinx 6 doesn't support linkcheck_anchors_ignore_for_url yet. I'll switch it for... linkcheck_anchors_ignore? |
…ll fix the other now undefined labels momentarily
|
I removed the last 2 missing labels, as the page/section they are supposed to link to does not exist afaict. I believe that was the last issue, I think build should now pass without any warnings/errors. |
RCheesley
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Awesome work @nick-vanpraet thanks so much for getting on top of this!
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #165 (partially atm)
So far: