-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPMMA-3031 Configurable email address length limit to prevent delivery issues #14577
DPMMA-3031 Configurable email address length limit to prevent delivery issues #14577
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.2 #14577 +/- ##
=========================================
Coverage 63.49% 63.49%
- Complexity 34637 34638 +1
=========================================
Files 2273 2273
Lines 103613 103621 +8
=========================================
+ Hits 65784 65792 +8
Misses 37829 37829
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/logs-are-full-of-mail-error/12245/3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good to me.
Just thinking If shouldn't be also part of EmailValidator https://github.com/mautic/mautic/blob/189dadcfb697e3985ef894ec9d66b6c0a3147fcb/app/bundles/EmailBundle/Helper/EmailValidator.php
But could be part of another PR.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this doesn't prevent email sending but only decides whether to add the contact name to the email address or not based on the length of the email address + name. I don't see an issue with this.
The provided tests shows this works as described. But I leave this open for additional manual test.
One thing is unclear. This looks more like an enhancement than a bug fix. Shouldn't we target 6.x instead of 5.2? |
@escopecz while this is technically an enhancement, it addresses an issue that prevents emails from being sent to a specific group of contacts. That's why I choose 5.2, but if you believe that version 6.x would be more appropriate, I can rebase it. |
I think technically this doesn't solve a bug in Mautic but in an integration. But that's politics. It might help fix an issue that Mautic users are having. Let's leave it in 5.2. |
Description
This PR introduces a new configuration option in the Email settings to set a maximum length limit for email addresses (including display names). This feature helps prevent delivery issues with email servers that have strict length restrictions.
Changes:
mailer_address_length_limit
in the Email settings📋 Steps to test this PR: