Update head components section at creating_themes.rst #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding issue mautic#247 Updating the head components section at creating_themes.rst to state most head components work, including mj-style
RCheesley
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks for making the PR @markusVJH and welcome to the community!
Here are a few fixes to bring this in line with our styleguide, should be quick to implement!
|
@all-contributors please add @markusVJH for docs |
|
I've put up a pull request to add @markusVJH! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #247. I since tested all of the mj-head components by sending real emails through Mautic.
This pr would update the head components section at creating_themes.rst to state that most head components do work, including mj-style.
Previously it stated that none of the head components work, and that all styling has to be inline. This has caused confusion in the past (Example 1, Example 2), as it did for me as a new Mautic user