Hide/Unhide themes documented #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how to deal with the last 2 Vale issues. Any suggestions? |
RCheesley
requested changes
Jun 13, 2024
Co-authored-by: Ruth Cheesley <[email protected]>
RCheesley
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Let's wrap that bit in a Vale Off so it doesn't flag the error. I'll make a PR to suggest a change to the wording.
The vale on/off needs a line break above and below, it wasn't totally clear from the GitHub UI whether that works with my suggestions so please just make sure the spacing comes out alright! :)
|
mautic/mautic#13835 PR to improve the grammar here :) |
Co-authored-by: Ruth Cheesley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change that documents mautic/mautic#13723