Prevent checkpoints for double puppeted events #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Jan 9, 2025
| @@ -0,0 +1,2 @@ | |||
| -- v19 (compatible with v9+): Add double puppeted state to messages | |||
| ALTER TABLE messages ADD COLUMN is_double_puppeted BOOLEAN NOT NULL; | |||
There was a problem hiding this comment.
Should leave it nullable or add a default, otherwise it's not actually compatible with v9+
There was a problem hiding this comment.
Good call, making it nullable so that we can debug old rows as "not having the information", I'm assuming the database layer will convert nulls to falses in the Go struct.
There was a problem hiding this comment.
It won't convert anything, you need to scan into a pointer or an sql.NullBool (see how the other nullable columns are scanned)
bradtgmurray
changed the title
tulir
deleted the
prevent-delivered-checkpoints-for-double-puppeted-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.