Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure markdown paragraphs are styled correctly #175

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

juanca
Copy link
Contributor

@juanca juanca commented Aug 12, 2020

Looks like Styleguidist might have a bug since it is not re-using the theme fontSizes

https://www.pivotaltracker.com/story/show/174214846
https://www.pivotaltracker.com/story/show/174263131

PR upkeep checklist

Looks like Styleguidist might have a bug since it is not re-using the theme fontSizes

Co-authored-by: Ben Nappier <[email protected]>
@juanca juanca self-assigned this Aug 12, 2020
@juanca juanca added the site label Aug 12, 2020
Copy link

@cincospenguinos cincospenguinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was easy

@juanca
Copy link
Contributor Author

juanca commented Aug 13, 2020

I reported the issue @ styleguidist/react-styleguidist#1661

I wonder if they'll fix it. If they do, we can clean up our config to be more concise.

@juanca juanca merged commit 7a40d1a into master Aug 17, 2020
@juanca juanca deleted the fix-site-typography branch August 17, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants