Add webrtc test via CI #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
force-pushed
the
webrtc-ci-test
branch
2 times, most recently
from
c3766b7 to
eae90d6
Compare
patrickelectric
force-pushed
the
webrtc-ci-test
branch
from
eae90d6 to
b05d7e0
Compare
patrickelectric
force-pushed
the
webrtc-ci-test
branch
from
b05d7e0 to
28e627f
Compare
patrickelectric
force-pushed
the
webrtc-ci-test
branch
2 times, most recently
from
49c3f91 to
82a4da3
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
webrtc-ci-test
branch
from
82a4da3 to
622561a
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
|
@joaoantoniocardoso I believe that it's ready to merge, indeed CI is failing, but at least we know that there is something wrong. |
joaoantoniocardoso
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runs fine locally with:
No idea why is failing on CI, crashing in a wrong scenario. I believe that @joaoantoniocardoso async rework may fix the issue on CI for this patch.