Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logger in riverpod #1266

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

YassinNouh21
Copy link
Contributor

📝 Summary

This PR for issue
create riverpod logger

Description

Tests

🧪 Use case 1

💬 Description:

📷 Screenshots or GIFs (if applicable):

Checklist:

  • Coding Standards: I have reviewed my code to ensure it follows the project's coding standards.
  • Testing: I have tested the changes and they work as expected.
  • Merge Conflicts: I have resolved any merge conflicts with the latest main/development branch.
  • Branch Status: The branch is up-to-date with the target branch (main/development).

Copy link
Contributor

@ghassenbenzahra123 ghassenbenzahra123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghassenbenzahra123 ghassenbenzahra123 merged commit f5c9ecd into main Aug 13, 2024
1 check passed
@ghassenbenzahra123 ghassenbenzahra123 deleted the feat/add-riverpod-logger branch August 13, 2024 13:26
YassinNouh21 added a commit that referenced this pull request Aug 13, 2024
YassinNouh21 added a commit that referenced this pull request Aug 14, 2024
ghassenbenzahra123 added a commit that referenced this pull request Aug 14, 2024
* feature the quran player

toggling between volume button and the button beside it id done wait for arabic test

* fix: directionality issues in Quran player screen

- Update skip previous/next button icons to respect RTL layout
- Refactor volume control to handle RTL directionality
- Implement proper focus management for volume control
- Add keyboard shortcuts and actions for improved accessibility
- Adjust icon sizes for consistency
- Clean up conditional rendering logic for volume slider/button

* feat: add volume slider thumb color and improve navigation controls

- Introduce _volumeSliderThumbColor for volume slider
- Add listener for volumeFocusNode to update thumb color
- Set thumb color for volume slider
- Simplify seek controls to use consistent direction regardless of text direction

* feat: add volume slider thumb color and improve navigation controls

- Introduce _volumeSliderThumbColor for volume slider
- Add listener for volumeFocusNode to update thumb color
- Set thumb color for volume slider
- Simplify seek controls to use consistent direction regardless of text direction

* fix: directionality of the icon of volume in play in the quran player

* add logging for  Null check operator used on a null value (#1264)

* refactor: add logging to `MosqueSimpleTile` for better error detection

* fix: format

* feat: add logger in riverpod (#1266)

* fix: PlatformException: PlatformException(channel-error, Unable to establish connection on channel., null, null)  (#1260)

* upgrade deprecated wakelock to wakelock plus

* move generate stream after ui render

* code format

* fix: center the icon at the button of the volume

---------

Co-authored-by: Ghassen Ben Zahra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants