Use bcrypt's built-in function for checking the password hash #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the method
check_password_hash
useshmac.compare_digest(bcrypt.hashpw(password, pw_hash), pw_hash)
to check if the password matches the provided hash. This is exactly how the bcrypt module implements itscheckpw
function. For the sake of reducing code duplication this should be replaced with bcrypt's provided function.