feat: create a DataRow builder #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to rebuild the UI without fetching new data
QuirijnGB
force-pushed
the
async-row-builder
branch
from
d6356e7
to
8130dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to move the DataRow building into separate builder method.
This allows us to store the raw data and rebuild the UI without having to fetch the data.
I needed this to allow for dynamically adding/removing/moving columns around.
The DataTable columns and the Datasource Columns would get out of sync causing assertion errors in the DataTable since the columns didn't match between the headers and the DataCells.
This solves my problem, but may not be the best solution.
Open to feedback/ideas