Merge pull request Nfactor26#86 from Nfactor26/fix-random-failure-in-…

…test-case Test_That_Can_NavigateToPrevious_If_Not_On_First_Page random failures
maximeozenne · Apr 4, 2023 · 4211080 · 4211080
2 parents 730b992 + 46a0c41
commit 4211080
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/src/Pixel.Identity.UI.Tests/PageModels/Applications/ListApplicationsPage.cs b/src/Pixel.Identity.UI.Tests/PageModels/Applications/ListApplicationsPage.cs
@@ -6,8 +6,6 @@ namespace Pixel.Identity.UI.Tests.PageModels.Applications;
 
 internal class ListApplicationsPage : ListPage
 {
-    private readonly string requestUrl = "api/applications";
-
     /// <summary>
     /// constructor
     /// </summary>

diff --git a/src/Pixel.Identity.UI.Tests/PageModels/Roles/ListRolesPage.cs b/src/Pixel.Identity.UI.Tests/PageModels/Roles/ListRolesPage.cs
@@ -5,9 +5,7 @@
 namespace Pixel.Identity.UI.Tests.PageModels.Roles;
 
 internal class ListRolesPage : ListPage
-{   
-    private readonly string requestUrl = "api/roles";
-
+{       
     /// <summary>
     /// constructor
     /// </summary>

diff --git a/src/Pixel.Identity.UI.Tests/Pixel.Identity.UI.Tests.csproj b/src/Pixel.Identity.UI.Tests/Pixel.Identity.UI.Tests.csproj
@@ -1,8 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
-    <Nullable>enable</Nullable>
+    <TargetFramework>net6.0</TargetFramework>   
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 

diff --git a/src/Pixel.Identity.UI.Tests/Tests/ApplicationsFixture.cs b/src/Pixel.Identity.UI.Tests/Tests/ApplicationsFixture.cs
@@ -197,13 +197,14 @@ public async Task Test_That_Can_NavigateToNext_When_Multiple_Pages_Are_Available
     public async Task Test_That_Can_NavigateToPrevious_If_Not_On_First_Page()
     {
         var listApplicationsPage = new ListApplicationsPage(this.Page);
-        await listApplicationsPage.GoToAsync();
-        await listApplicationsPage.NavigateToNextAsync();
+        await listApplicationsPage.GoToAsync();     
+        Assert.AreEqual(10, await listApplicationsPage.GetCountAsync());
+        await listApplicationsPage.NavigateToNextAsync();       
+        Assert.AreEqual(2, await listApplicationsPage.GetCountAsync());
         var canNavigateToPrevious = await listApplicationsPage.CanNavigateToPrevious();
         Assert.IsTrue(canNavigateToPrevious);
-        await listApplicationsPage.NavigateToPreviousAsync();
-        int scopesCount = await listApplicationsPage.GetCountAsync();
-        Assert.AreEqual(10, scopesCount);
+        await listApplicationsPage.NavigateToPreviousAsync();      
+        Assert.AreEqual(10, await listApplicationsPage.GetCountAsync());
         await Expect(this.Page).ToHaveURLAsync(new Regex(".*/applications/list"));
     }