refactor: Updated go-i18n API to support v2 and v1 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2023
Aerex
commented
Jul 20, 2023
| ) | ||
|
|
||
| var T goi18n.TranslateFunc | ||
| var T i18n.TranslateFunc |
There was a problem hiding this comment.
Callout: To avoid disruption the API i18n.TranslateFunc method looks the same as the TranslateFunc from goi18n from version 1
Aerex
commented
Jul 20, 2023
| localizer := go_i18n.NewLocalizer(bundle, DEFAULT_LOCALE) | ||
| tfunc := translate(localizer) | ||
| for _, s := range sources { | ||
| if s == "" { |
There was a problem hiding this comment.
Callout: If we can't determine the language source we will just skip it. I am open to other suggestions.
|
Looks great to me. Passed all tests and tried a few more manual tests too and all good. Nice contrib :) |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is a security vulnerability using version 1 of go-i18n so we need to update. However, the V2 API for go-i18n is significantly different from the older versions. To ensure that we don't break backwards compatibility, a wrapper was made around the V2 API using the V1.
Steps to Test
Run Unit Tests
Note: The unit tests for rewrite-package uses the go-i18n template to generate a i18n.go file for handling translations. This should sufficient to test the refactoring
./bin/test