Skip to content

Commit

Permalink
Add NET 8.0 and NET 7.0 targets
Browse files Browse the repository at this point in the history
  • Loading branch information
oschwald committed Nov 15, 2023
1 parent 8f79bc2 commit 1e061d8
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
dotnet-version: |
3.1.x
6.0.x
7.0.x
8.0.x
- name: Build
Expand All @@ -32,7 +33,7 @@ jobs:
dotnet build MaxMind.Db.Test
- name: Run benchmark
run: dotnet run -f net6.0 --project MaxMind.Db.Benchmark/MaxMind.Db.Benchmark.csproj
run: dotnet run -f net8.0 --project MaxMind.Db.Benchmark/MaxMind.Db.Benchmark.csproj
env:
MAXMIND_BENCHMARK_DB: ${{ github.workspace }}/MaxMind.Db.Test/TestData/MaxMind-DB/test-data/GeoIP2-City-Test.mmdb

Expand Down
4 changes: 2 additions & 2 deletions MaxMind.Db.Benchmark/MaxMind.Db.Benchmark.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<PropertyGroup>
<Description>Benchmark project to validate .NET reader for the MaxMind DB file format</Description>
<VersionPrefix>4.0.0</VersionPrefix>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net6.0;net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">net6.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net8.0;net7.0;net6.0;net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">net8.0;net7.0;net6.0</TargetFrameworks>
<AssemblyName>MaxMind.Db.Benchmark</AssemblyName>
<OutputType>Exe</OutputType>
<PackageId>MaxMind.Db.Benchmark</PackageId>
Expand Down
4 changes: 2 additions & 2 deletions MaxMind.Db.Test/MaxMind.Db.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<PropertyGroup>
<Description>Test project to validate .NET reader for the MaxMind DB file format</Description>
<VersionPrefix>4.0.0</VersionPrefix>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net6.0;net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">net6.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net8.0;net7.0;net6.0;net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">net8.0;net7.0;net6.0</TargetFrameworks>
<AssemblyName>MaxMind.Db.Test</AssemblyName>
<AssemblyOriginatorKeyFile>../MaxMind.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
Expand Down
2 changes: 1 addition & 1 deletion MaxMind.Db/MaxMind.Db.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<Description>.NET reader for the MaxMind DB file format</Description>
<VersionPrefix>4.0.0</VersionPrefix>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net8.0;net7.0;net6.0;netstandard2.1;netstandard2.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<AssemblyName>MaxMind.Db</AssemblyName>
<AssemblyOriginatorKeyFile>../MaxMind.snk</AssemblyOriginatorKeyFile>
Expand Down
1 change: 1 addition & 0 deletions releasenotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* .NET 5.0 has been removed as a target as it has reach its end of life.
However, if you are using .NET 5.0, the .NET Standard 2.1 target should
continue working for you.
* .NET 7.0 and .NET 8.0 have been added as a target.

## 4.0.0 (2022-02-03) ##

Expand Down

0 comments on commit 1e061d8

Please sign in to comment.