Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for new golangci-lint #346

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Updates for new golangci-lint #346

merged 2 commits into from
Nov 14, 2024

Conversation

oschwald
Copy link
Member

  • Remove deactivated linters
  • Don't mix receiver type

@oschwald oschwald force-pushed the greg/upgrade-golangci-lint branch from ce3fc2d to d9ff683 Compare November 11, 2024 17:50
@github-actions GitHub Actions
Copy link

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's patchlevel.

no object ReadResult.MarshalJSON in new version of package github.com/maxmind/geoipupdate/v7/internal/geoipupdate/database
  Patchlevel

@horgh horgh merged commit 739e5dc into main Nov 14, 2024
17 checks passed
@horgh horgh deleted the greg/upgrade-golangci-lint branch November 14, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horgh horgh horgh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oschwald @horgh