Implemented being able to toggle audio recording #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leroydev
force-pushed
the
feature/record-audio-setting
branch
from
7309594 to
83e3920
Compare
|
My bad, rebase went wrong.. Should be okay now, I squashed the commits :) |
|
Thank you @leroydev for your contribution, very much appreciated! Sorry for the delay, but I will review this soon and release an update. |
|
@maxneaga Ping :) |
maxneaga
reviewed
Oct 4, 2020
| mediaRecorder.setAudioSource(MediaRecorder.AudioSource.CAMCORDER); | ||
| mediaRecorder.setProfile(camcorderProfile); | ||
| } else { | ||
| mediaRecorder.setOutputFormat(MediaRecorder.OutputFormat.MPEG_4); |
There was a problem hiding this comment.
With the else predicate here, does it mean that the video parameters will be set only when record_audio is false?
Don't we need them for both with and without audio? Need to check this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to make changes if needed, and I can squash the commits if wanted. :)
Closes #14.
Screenshot: