Merge pull request nf-core#1410 from nf-core/fix_empty_trimming

Fix issues caused by empty versions from trimming subworkflows
maxulysse · Oct 15, 2024 · 660d10c · 660d10c
2 parents 7794c69 + a391518
commit 660d10c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ Special thanks to the following for their contributions to the release:
 - [PR #1401](https://github.com/nf-core/rnaseq/pull/1401) - Template update for nf-core/tools v3.0.1
 - [PR #1405](https://github.com/nf-core/rnaseq/pull/1405) - Fix bad variable name in subworkflow
 - [PR #1406](https://github.com/nf-core/rnaseq/pull/1406) - Keep only one samplesheetToList
+- [PR #1410](https://github.com/nf-core/rnaseq/pull/1410) - Fix issues caused by empty versions from trimming subworkflows
 
 ### Parameters
 

diff --git a/modules.json b/modules.json
@@ -327,17 +327,17 @@
                     },
                     "fastq_fastqc_umitools_fastp": {
                         "branch": "master",
-                        "git_sha": "46eca555142d6e597729fcb682adcc791796f514",
+                        "git_sha": "4026bab16a91b1b0b18d80ff465819ca725f33fd",
                         "installed_by": ["fastq_qc_trim_filter_setstrandedness", "subworkflows"]
                     },
                     "fastq_fastqc_umitools_trimgalore": {
                         "branch": "master",
-                        "git_sha": "53fcc37e256ea30818fb793bbe98b63e4a40deb8",
+                        "git_sha": "4026bab16a91b1b0b18d80ff465819ca725f33fd",
                         "installed_by": ["fastq_qc_trim_filter_setstrandedness", "subworkflows"]
                     },
                     "fastq_qc_trim_filter_setstrandedness": {
                         "branch": "master",
-                        "git_sha": "aef0e7467478130e861365232c3c4cc3247938ec",
+                        "git_sha": "9082d6440bdffbb4f5d9bd9d753361933b3febcb",
                         "installed_by": ["subworkflows"]
                     },
                     "fastq_subsample_fq_salmon": {

diff --git a/subworkflows/nf-core/fastq_fastqc_umitools_fastp/main.nf b/subworkflows/nf-core/fastq_fastqc_umitools_fastp/main.nf
diff --git a/subworkflows/nf-core/fastq_fastqc_umitools_trimgalore/main.nf b/subworkflows/nf-core/fastq_fastqc_umitools_trimgalore/main.nf
diff --git a/subworkflows/nf-core/fastq_fastqc_umitools_trimgalore/tests/main.nf.test.snap b/subworkflows/nf-core/fastq_fastqc_umitools_trimgalore/tests/main.nf.test.snap