Merge pull request #48 from wethersherbs/dev-0.3.x

Send DB_ERROR_UNSUPPORTED if seeking in pdo_mysql
may-den · Feb 2, 2017 · 081103c · 081103c
2 parents 4c9d558 + 29cb957
commit 081103c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/DB/Driver/DoctrineDbal.php b/src/DB/Driver/DoctrineDbal.php
@@ -164,6 +164,18 @@ public function simpleQuery($query)
      */
     public function fetchInto(StatementContainer $result, &$arr, $fetchmode, $rownum = null)
     {
+        // @codeCoverageIgnoreStart
+        // This is not coverable by integration tests
+        if (isset($rownum) && ($rownum !== null) && ($this->getPlatform() === 'mysql')) {
+            return $this->raiseError(
+                DB::DB_ERROR_UNSUPPORTED,
+                null,
+                null,
+                'pdo_mysql does not support cursor seeking'
+            );
+        }
+        // @codeCoverageIgnoreEnd
+
         if ($fetchmode & DB::DB_FETCHMODE_ASSOC) {
             $arr = self::getStatement($result)->fetch(PDO::FETCH_ASSOC, null, $rownum);
             if (($this->options['portability'] & DB::DB_PORTABILITY_LOWERCASE) && $arr) {

diff --git a/src/DB/Driver/PdoDriver.php b/src/DB/Driver/PdoDriver.php
@@ -203,6 +203,18 @@ private static function formatErrorInfo(array $errorInfo)
      */
     public function fetchInto(StatementContainer $result, &$arr, $fetchmode, $rownum = null)
     {
+        // @codeCoverageIgnoreStart
+        // This is not coverable by integration tests
+        if (isset($rownum) && ($rownum !== null) && ($this->getPlatform() === 'mysql')) {
+            return $this->raiseError(
+                DB::DB_ERROR_UNSUPPORTED,
+                null,
+                null,
+                'pdo_mysql does not support cursor seeking'
+            );
+        }
+        // @codeCoverageIgnoreEnd
+
         if ($fetchmode & DB::DB_FETCHMODE_ASSOC) {
             $arr = self::getStatement($result)->fetch(PDO::FETCH_ASSOC, null, $rownum);
             if (($this->options['portability'] & DB::DB_PORTABILITY_LOWERCASE) && $arr) {