Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Directive::XR_SPATIAL_TRACKING injects vr header value instead of xr-spatial-tracking #55

Closed
1 task done
cemrich opened this issue Mar 6, 2024 · 3 comments · Fixed by #57
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@cemrich
Copy link

cemrich commented Mar 6, 2024

Contact Details

[email protected]

What happened?

I am running v2.1 and using the Directive::XR_SPATIAL_TRACKING directive, in a custom FeaturePolicy like so:

<?php

namespace App\Http\FeaturePolicies;

use Mazedlx\FeaturePolicy\Directive;
use Mazedlx\FeaturePolicy\Policies\Policy;

class CustomFeaturePolicy extends Policy
{
    public function configure(): void
    {
        $this->addDirective(Directive::XR_SPATIAL_TRACKING, [
            'self',
            'https://sketchfab.com/',
        ]);
    }
}

This does inject the Permissions-Policy header just fine, uses the correct origin values, but uses the outdated vr key instead of xr-spatial-tracking:

grafik

Chrome 122 is not happy with this key:
grafik

Given the fact, that there is a Directive::VR property for people to use, I would consider this behaviour a bug.

Thank you very much for this great package and please let me know, if you need more context!

(PS: The code of conduct leads to example.com)

Version

2.0.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@cemrich cemrich added bug Something isn't working triage Need more info labels Mar 6, 2024
@mazedlx mazedlx linked a pull request Mar 6, 2024 that will close this issue
3 tasks
@mazedlx mazedlx removed the triage Need more info label Mar 6, 2024
@mazedlx
Copy link
Owner

mazedlx commented Mar 6, 2024

@cemrich thank you for bringing this to our attention, the bug is fixed in the latest release.

@cemrich
Copy link
Author

cemrich commented Mar 6, 2024

Thanks a whole lot for your work!

@mazedlx
Copy link
Owner

mazedlx commented Mar 6, 2024

We're happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants