Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test. Update method to return the correct name. #57

Conversation

mazedlx
Copy link
Owner

@mazedlx mazedlx commented Mar 6, 2024

What does this pull request change or introduce

Fix bug mentioned in #55

What is the impact of these changes

Updated the DefaultFeatureGroup class to return the correct directive for xr-spatial-tracking. Added a test.

Checklist

  • An issue was created before proposing this change
  • Tests for the changes have been added
  • Tests are passing

Steps to reproduce / test

  1. run phpunit

Other information:

@mazedlx mazedlx merged commit e25f1d0 into main Mar 6, 2024
12 checks passed
@mazedlx mazedlx self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Directive::XR_SPATIAL_TRACKING injects vr header value instead of xr-spatial-tracking
1 participant