Fix relative paths to custom upload method file, fix incorrect CAN length on STMicro #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Noticed while working on the custom targets example that if you pass a relative path to CUSTOM_UPLOAD_CFG_PATH, it errors out, because EXISTS in CMake only works with absolute paths (seriously this is such a common foot-gun and they still have not fixed it).
Also noticed a compiler warning coming from the STM32 CAN code. It appears that there was some unintentional behavior happening because the
<
operator has higher precedence than&
, so the comparison was happening before the mask! It looks like they were trying to get the length from the DLC field, so I updated the code to use a proper register definition and parentheses as needed.Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results