Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative paths to custom upload method file, fix incorrect CAN length on STMicro #380

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

Noticed while working on the custom targets example that if you pass a relative path to CUSTOM_UPLOAD_CFG_PATH, it errors out, because EXISTS in CMake only works with absolute paths (seriously this is such a common foot-gun and they still have not fixed it).

Also noticed a compiler warning coming from the STM32 CAN code. It appears that there was some unintentional behavior happening because the < operator has higher precedence than &, so the comparison was happening before the mask! It looks like they were trying to get the length from the DLC field, so I updated the code to use a proper register definition and parentheses as needed.
image

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@multiplemonomials multiplemonomials merged commit d46739b into master Nov 15, 2024
52 checks passed
@multiplemonomials multiplemonomials deleted the dev/fix-relative-custom-upload-path branch November 15, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants