Support override of memory_bank_config in mbed_app.json #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memory_bank_config can be defined in targets.json or custom_targets.json per-target, but cannot by application. This enables this override by adding "target.memory_bank_config" config in target_overrides section of mbed_app.json as usual.
|
To be honest, I am not in love with how this adds a special exception to the processing of JSON files, something which is already full of strange logic and poorly documented. However, I think this adds a very useful feature, and I don't see another readily available option for doing this. So, after thinking about it a bit, I am good to merge this. |
multiplemonomials
approved these changes
Nov 18, 2024
|
Updated the doc page here: https://github.com/mbed-ce/mbed-os/wiki/Mbed-Memory-Bank-Information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
memory_bank_configcan be defined in targets.json or custom_targets.json per-target, but cannot by application. This enables this override by addingtarget.memory_bank_configconfig intarget_overridessection of mbed_app.json as usual.Fix #370.
Pull request type