Skip to content

Commit

Permalink
Remove access+secret AWS keys for GitHub OIDC
Browse files Browse the repository at this point in the history
  • Loading branch information
mbland committed Sep 11, 2023
1 parent 3f3d83e commit 11d0c49
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions .github/workflows/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ jobs:
- name: Assume the testing pipeline user role
uses: aws-actions/configure-aws-credentials@v3
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.DEV_REGION }}
role-to-assume: ${{ env.DEV_PIPELINE_EXECUTION_ROLE }}
role-session-name: testing-packaging
Expand Down Expand Up @@ -89,8 +87,6 @@ jobs:
- name: Assume the testing pipeline user role
uses: aws-actions/configure-aws-credentials@v3
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.DEV_REGION }}
role-to-assume: ${{ env.DEV_PIPELINE_EXECUTION_ROLE }}
role-session-name: feature-deployment
Expand Down Expand Up @@ -128,8 +124,6 @@ jobs:
- name: Assume the testing pipeline user role
uses: aws-actions/configure-aws-credentials@v3
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.DEV_REGION }}
role-to-assume: ${{ env.DEV_PIPELINE_EXECUTION_ROLE }}
role-session-name: testing-packaging
Expand Down Expand Up @@ -159,8 +153,6 @@ jobs:
- name: Assume the prod pipeline user role
uses: aws-actions/configure-aws-credentials@v3
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.PROD_REGION }}
role-to-assume: ${{ env.PROD_PIPELINE_EXECUTION_ROLE }}
role-session-name: prod-packaging
Expand Down Expand Up @@ -195,8 +187,6 @@ jobs:
- name: Assume the testing pipeline user role
uses: aws-actions/configure-aws-credentials@v3
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.DEV_REGION }}
role-to-assume: ${{ env.DEV_PIPELINE_EXECUTION_ROLE }}
role-session-name: testing-deployment
Expand Down Expand Up @@ -249,8 +239,6 @@ jobs:
- name: Assume the prod pipeline user role
uses: aws-actions/configure-aws-credentials@v3
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.PROD_REGION }}
role-to-assume: ${{ env.PROD_PIPELINE_EXECUTION_ROLE }}
role-session-name: prod-deployment
Expand Down

0 comments on commit 11d0c49

Please sign in to comment.