Skip to content

Commit

Permalink
WIP: Bzlmod part the thirty-fourth
Browse files Browse the repository at this point in the history
Added a couple more repo dependencies to targets under //test.

However, `bazel test //test:all` is a bust for now, because the
protoc-bridge mechanism hangs on macOS:

- scalapb/protoc-bridge#366
- scalapb/protoc-bridge#367
- scalapb/protoc-bridge#379
- scalapb/protoc-bridge#380

Though scalapb/protoc-bridge#366 suggests that it only hangs
occasionally, it's hanging 100% of the time for me on macOS 15.0 on a M3
Max.
  • Loading branch information
mbland committed Oct 1, 2024
1 parent 51ea4a5 commit 59d05e2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -610,9 +610,14 @@ scala_library(
],
)

junit_deps = [
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
]

scala_library(
name = "customJunitRunner",
srcs = ["src/main/scala/scalarules/test/junit/JunitCustomRunner.java"],
deps = junit_deps,
)

# make sure making a fat jar strips signatures
Expand Down Expand Up @@ -696,10 +701,6 @@ check_statsfile("ScalaLibBinary")

#discovering tests from a separate target

junit_deps = [
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
]

scala_library(
name = "JunitSeparateTarget",
srcs = ["src/main/scala/scalarules/test/junit/separate_target/JunitSeparateTargetTest.scala"],
Expand Down
1 change: 1 addition & 0 deletions test/src/main/scala/scalarules/test/fetch_sources/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ scala_library(
name = "fetch_sources",
testonly = True,
srcs = ["FetchSources.scala"],
deps = ["@com_google_guava_guava_21_0"],
)

0 comments on commit 59d05e2

Please sign in to comment.