Allow building on BSD/Solaris/etc with CMake #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not only GNU systems that need libm linked. Note, the tests still fail with: error: ‘M_PIl’ was not declared in this scope; did you mean ‘M_PI’? 46 | long double phinc = 2*k0* M_PIl / nfft; Signed-off-by: Nia Alarie <[email protected]>
JayFoxRox
reviewed
May 9, 2021
| @@ -105,7 +105,7 @@ endif() | |||
| # Add GNUInstallDirs for GNU infrastructure before target)include_directories | |||
| # | |||
|
|
|||
| if(CMAKE_SYSTEM_NAME MATCHES "^(Linux|kFreeBSD|GNU)$" AND NOT CMAKE_CROSSCOMPILING) | |||
| if(UNIX AND NOT CMAKE_CROSSCOMPILING) | |||
And cross-compilers need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not only GNU systems that need libm linked.
Note, the tests still fail for me with:
error: ‘M_PIl’ was not declared in this scope; did you mean ‘M_PI’?
46 | long double phinc = 2k0 M_PIl / nfft;
Signed-off-by: Nia Alarie [email protected]