Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach html element before calling onCreateLi #846

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

mbraak
Copy link
Owner

@mbraak mbraak commented Oct 14, 2024

Fixes #844

Copy link

Size Change: +34 B (+0.12%)

Total Size: 28.3 kB

Filename Size Change
./lib/elementsRenderer.js 1.86 kB +34 B (+1.86%)
ℹ️ View Unchanged
Filename Size
./lib/dataLoader.js 863 B
./lib/dragAndDropHandler/dragElement.js 432 B
./lib/dragAndDropHandler/generateHitAreas.js 1.2 kB
./lib/dragAndDropHandler/index.js 2.19 kB
./lib/dragAndDropHandler/iterateVisibleNodes.js 547 B
./lib/dragAndDropHandler/types.js 33 B
./lib/jqtreeMethodTypes.js 33 B
./lib/jqtreeOptions.js 33 B
./lib/keyHandler.js 819 B
./lib/mouseHandler.js 1.5 kB
./lib/mouseUtils.js 233 B
./lib/node.js 3.22 kB
./lib/nodeElement/borderDropHint.js 390 B
./lib/nodeElement/folderElement.js 915 B
./lib/nodeElement/ghostDropHint.js 342 B
./lib/nodeElement/index.js 718 B
./lib/nodeUtils.js 192 B
./lib/position.js 382 B
./lib/saveStateHandler.js 1.49 kB
./lib/scrollHandler.js 461 B
./lib/scrollHandler/containerScrollParent.js 871 B
./lib/scrollHandler/createScrollParent.js 512 B
./lib/scrollHandler/documentScrollParent.js 1.06 kB
./lib/scrollHandler/types.js 33 B
./lib/selectNodeHandler.js 676 B
./lib/simple.widget.js 954 B
./lib/tree.jquery.js 5.88 kB
./lib/util.js 347 B
./lib/version.js 147 B

compressed-size-action

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (97fb9a5) to head (9ebb458).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #846      +/-   ##
==========================================
- Coverage   95.32%   95.32%   -0.01%     
==========================================
  Files          30       30              
  Lines        2288     2287       -1     
  Branches      579      579              
==========================================
- Hits         2181     2180       -1     
  Misses        107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbraak mbraak merged commit 76d30ca into dev Oct 17, 2024
6 checks passed
@mbraak mbraak deleted the attach-html-element-before-calling-on-create-li branch October 17, 2024 05:59
@mbraak mbraak changed the title Attach html element before calling on create li Attach html element before calling onCreateLi Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is removeFromSelection working for version 1.8.5 ?
1 participant