feat: polish to replacement_service form #1106
Merged
+28
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meagharty
force-pushed
the
meag/add-replacement-service-with-form-save
branch
from
85e093a to
9d334fb
Compare
meagharty
commented
Feb 3, 2025
| @@ -3441,7 +3441,6 @@ fieldset:disabled a.btn { | |||
| padding: 0.25rem 0.5rem; | |||
| font-size: 0.875rem; | |||
| line-height: 1.5; | |||
| border-radius: 0.2rem; | |||
There was a problem hiding this comment.
A quick stab at making these buttons distinct from the disruptions save/cancel.
Left is with border-radius (before this line removal, it was pretty square-looking), which is coming from this btn-sm class. On the right is the existing button, btn-primary without btn-sm.
We're aren't using this class btn-sm elsewhere that I can see.
There was a problem hiding this comment.
For clarity, changes in the PR:
| @@ -175,15 +175,15 @@ defmodule ArrowWeb.LimitSection do | |||
| </div> | |||
| <div class="row"> | |||
| <div class="col-lg-3"> | |||
| <.button type="submit" class="btn btn-primary w-100" phx-target={@myself}> | |||
| <.button type="submit" class="btn-primary btn-sm w-100" phx-target={@myself}> | |||
There was a problem hiding this comment.
I removed btn from class= because the .button already had this class applied.
meagharty
requested review from
a team and
jzimbel-mbta
and removed request for
a team
meagharty
force-pushed
the
meag/polish-replacement-service-form
branch
from
d6fb476 to
a72156b
Compare
Base automatically changed from
meag/add-replacement-service-with-form-save
to
master
February 4, 2025 16:42
An error occurred while trying to automatically change base from
meag/add-replacement-service-with-form-save
to
master
February 4, 2025 16:42
meagharty
force-pushed
the
meag/polish-replacement-service-form
branch
from
a72156b to
2cc7ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Follow on to 🏹 Implement "Create Replacement Service Component" - Shuttle Activation Upload/Parsing + Save Component Button
Reviewer Checklist