Merge branch 'cbj/trip-planner-input-errors' into cbj/trip-planner-in…

…put-improvements
mbta · Feb 5, 2025 · 6bf251b · 6bf251b
2 parents 8d40e15 + 64893a8
commit 6bf251b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/assets/ts/ui/autocomplete/config.ts b/assets/ts/ui/autocomplete/config.ts
@@ -211,9 +211,11 @@ const TRIP_PLANNER = ({
       pushToLiveView({});
     },
     onStateChange({ prevState, state }) {
-      // Send changed input text to LiveView
-      if (state.query !== prevState.query) {
-        const newInputData = state.query === "" ? {} : { name: state.query };
+      const isCleared = state.query === "";
+      const changedToClosedState = prevState.isOpen && !state.isOpen;
+      // Send changed input text to LiveView when leaving this input
+      if (changedToClosedState) {
+        const newInputData = isCleared ? {} : { name: state.query };
         pushToLiveView(newInputData);
       }
     },

diff --git a/test/dotcom/trip_plan/input_form_test.exs b/test/dotcom/trip_plan/input_form_test.exs
@@ -60,6 +60,23 @@ defmodule Dotcom.TripPlan.InputFormTest do
       refute changeset.errors[:from]
     end
 
+    test "adds error if invalid location" do
+      changeset =
+        InputForm.changeset(%{
+          "to" => %{
+            "latitude" => "",
+            "longitude" => "",
+            "name" => Faker.Cat.breed(),
+            "stop_id" => ""
+          }
+        })
+
+      refute changeset.valid?
+
+      expected_error = InputForm.error_message(:to)
+      assert {^expected_error, _} = changeset.errors[:to]
+    end
+
     test "adds error if from & to are the same" do
       changeset =
         InputForm.changeset(%{