Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralized CMS caching 2 #1832

Closed
wants to merge 33 commits into from
Closed

Centralized CMS caching 2 #1832

wants to merge 33 commits into from

Conversation

anthonyshull
Copy link
Contributor

@anthonyshull anthonyshull force-pushed the ags/centralized-cms-caching-2 branch from 2906e03 to 5c2ce97 Compare December 18, 2023 14:18
@anthonyshull anthonyshull marked this pull request as ready for review December 18, 2023 19:58
@anthonyshull anthonyshull requested review from amaisano and a team as code owners December 18, 2023 19:58
kotva006
kotva006 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@kotva006 kotva006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look fine. Though it would be nice if this was pointing at the first pull request seeing as the changes are duplicated here (and aren't reflecting the feedback from the first pull request)

@anthonyshull
Copy link
Contributor Author

The changes here look fine. Though it would be nice if this was pointing at the first pull request seeing as the changes are duplicated here (and aren't reflecting the feedback from the first pull request)

The differences will shake out when the first PR is merged into master.

@anthonyshull anthonyshull force-pushed the ags/centralized-cms-caching-2 branch from befebb8 to e6d5800 Compare December 20, 2023 20:39
@anthonyshull anthonyshull force-pushed the ags/centralized-cms-caching-2 branch from 1fcb5bb to ed3f986 Compare January 3, 2024 20:51
@thecristen
Copy link
Collaborator

Complete in #1856

@thecristen thecristen closed this Jan 23, 2024
@thecristen thecristen deleted the ags/centralized-cms-caching-2 branch January 23, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotva006 kotva006 kotva006 approved these changes

@amaisano amaisano Awaiting requested review from amaisano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthonyshull @thecristen @kotva006