Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AlertController): put new features on the subway alerts page #2395

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

thecristen
Copy link
Collaborator

Summary of changes

Asana Ticket: Service Alerts page | Refine Station and Service Alerts section and Service Alerts page | Add "Current Status" section for subway

image

Most of the changes here were adding an additional sub-layout for the content of the alert page. Everything's the same between modes except for:

  • the icon shown next to each route (for subway it's the subway_route_pill, all others route_icon)
  • the <h2> shown above the list of alerts, as there's no heading shown for non-subway
  • I changed the verbiage of the "no alerts here" message for subway to read more like "no other alerts here", since there might be other alerts covered by the Current Status or Planned Disruptions sections
  • and of course, the new sections are only included for subway

Outside of the main content, the timeframe filters are also omitted from the sidebar for subway only.

Hopefully the structure is clear enough. Please omit the first commit from review, as it is already covered in #2388

@thecristen thecristen requested a review from a team as a code owner February 21, 2025 16:55
@thecristen thecristen added the dev-green Deploy to dev-green label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-green Deploy to dev-green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants