FEAT: Write Bus Performance metrics to S3 Bucket #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
arkadyan
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
👍 Just one tiny question.
I appreciate the PR description.
In the future, if it's possible to separate out things like this formatting change into an isolated PR or commit, that would make it easier to quickly rubber stamp that bit and better understand which are the functional changes worth looking closer at.
| """ | ||
| Test that bus routes be generated for a given service date. For the | ||
| generated list ensure | ||
| * they don't contain Subway, Commuter Rail, or Ferry routes | ||
| * don't have a leading zero | ||
| * contain a subset of known routes | ||
| """ | ||
| assert True | ||
| exists_patch.return_value = True |
There was a problem hiding this comment.
question: Does this still need the assert?
There was a problem hiding this comment.
I don't think so. That assert is essentially a no-op. My guess is that it was in there as a place-holder before the full test function was written, and then it was never removed.
There was a problem hiding this comment.
👍 got it. I also spaced out on the single vs double =.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates real-time bus performance parquet files and writes them to a partition on the S3
PUBLIC_ARCHIVE_BUCKET.This process has been successfully run locally (using staging bucket data) and on the
devenvironment.Files are generated for each service date with the following steps:
RT_VEHICLE_POSITIONspringboard filesTM/STOP_CROSSINGspringboard filesThis PR also contains a linting change that increases minimum line length from 80 to 120 lines, so many files are no-op formatting changes.
Asana Task: https://app.asana.com/0/1205827492903547/1208021735441632