Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app setup] Basic files for new triptych app #1829

Merged
merged 3 commits into from
Aug 3, 2023
Merged

[app setup] Basic files for new triptych app #1829

merged 3 commits into from
Aug 3, 2023

Conversation

hannahpurcell
Copy link
Contributor

@hannahpurcell hannahpurcell requested review from a team and jzimbel-mbta and removed request for a team August 1, 2023 16:12
@hannahpurcell hannahpurcell requested review from a team and cmaddox5 and removed request for jzimbel-mbta and a team August 1, 2023 16:13
cmaddox5
cmaddox5 requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions that should help resolve the CI errors.

lib/screens/config/v2/triptych.ex Outdated Show resolved Hide resolved
lib/screens/config/v2/ol_crowding.ex Outdated Show resolved Hide resolved
lib/screens/config/v2/ol_crowding.ex Outdated Show resolved Hide resolved
lib/screens/config/v2/ol_crowding.ex Show resolved Hide resolved
@cmaddox5 cmaddox5 assigned hannahpurcell and unassigned cmaddox5 Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Coverage of commit 13f46a4

Summary coverage rate:
  lines......: 41.0% (2228 of 5439 lines)
  functions..: 42.1% (1014 of 2409 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/screen.ex                                             |75.0%     20|75.0%     8|    -      0
  lib/screens/config/v2/ol_crowding.ex                                     | 0.0%      1| 0.0%     2|    -      0
  lib/screens/config/v2/triptych.ex                                        | 0.0%      1| 0.0%     2|    -      0
  lib/screens/v2/candidate_generator/triptych.ex                           | 0.0%      7| 0.0%     5|    -      0
  lib/screens/v2/screen_data/parameters.ex                                 |37.5%      8|75.0%     4|    -      0

Download coverage report

cmaddox5
cmaddox5 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cmaddox5 cmaddox5 assigned hannahpurcell and unassigned cmaddox5 Aug 3, 2023
@hannahpurcell hannahpurcell merged commit b01df90 into master Aug 3, 2023
2 checks passed
@hannahpurcell hannahpurcell deleted the hp/triptych-backend-setup branch August 3, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaddox5 cmaddox5 cmaddox5 approved these changes

Assignees

@hannahpurcell hannahpurcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahpurcell @cmaddox5 @jzimbel-mbta