Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Suppress automated alerts on pre-fares & DUPs, for October RL maintenance diversion #1887

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

jzimbel-mbta
Copy link
Member

Asana task: ad hoc?

The two alerts are "two sides of the same coin"—one informs southbound trips and the other northbound, because using a single alert for both directions caused problems for JFK countdown clocks.

  • Tests added?

@jzimbel-mbta jzimbel-mbta requested review from a team and cmaddox5 and removed request for a team October 13, 2023 20:46
@cmaddox5 cmaddox5 assigned jzimbel-mbta and unassigned cmaddox5 Oct 13, 2023
@jzimbel-mbta jzimbel-mbta merged commit 2520383 into master Oct 13, 2023
4 checks passed
@jzimbel-mbta jzimbel-mbta deleted the jz/suppress-rl-mattapan-october-alerts branch October 13, 2023 21:06
@github-actions
Copy link

Coverage of commit fffe23a

Summary coverage rate:
  lines......: 40.4% (2297 of 5692 lines)
  functions..: 41.8% (1050 of 2512 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/v2/widget_instance/dup_alert.ex                              | 0.0%     62| 0.0%    20|    -      0
  lib/screens/v2/widget_instance/reconstructed_alert.ex                    |90.4%    166| 100%    22|    -      0

Download coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants