Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cm/crowding app wording updates #1888

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Cm/crowding app wording updates #1888

merged 3 commits into from
Oct 18, 2023

Conversation

cmaddox5
Copy link
Contributor

Asana task: Make text changes on crowding app

Made wording changes to plain JS app and updated React app so it matches the plain JS.

  • Tests added?

@cmaddox5 cmaddox5 requested review from a team and jzimbel-mbta and removed request for a team October 17, 2023 13:33
@github-actions
Copy link

Coverage of commit e6d7a51

Summary coverage rate:
  lines......: 40.4% (2296 of 5684 lines)
  functions..: 41.8% (1051 of 2512 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

hannahpurcell
hannahpurcell approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thanks for fixing for both the app versions

@cmaddox5 cmaddox5 merged commit 02e7964 into jz/plain-js-triptych-app Oct 18, 2023
1 check passed
@cmaddox5 cmaddox5 deleted the cm/crowding-app-wording-updates branch October 18, 2023 14:40
@github-actions
Copy link

Coverage of commit a153a93

Summary coverage rate:
  lines......: 40.4% (2296 of 5684 lines)
  functions..: 41.8% (1051 of 2512 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

@jzimbel-mbta jzimbel-mbta jzimbel-mbta approved these changes

Assignees

@cmaddox5 cmaddox5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaddox5 @jzimbel-mbta @hannahpurcell