Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cm/e branch headsign fix #1900

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Cm/e branch headsign fix #1900

merged 4 commits into from
Oct 31, 2023

Conversation

cmaddox5
Copy link
Contributor

Notion task: [alert, backend] Wrong banner pill for Medford/Tufts (E) branch alert

E Branch was showing Union Square as endpoint. Changed to Medford/Tufts.

  • Tests added?

@cmaddox5 cmaddox5 requested review from a team and hannahpurcell and removed request for a team October 27, 2023 12:27
@github-actions
Copy link

Coverage of commit 2c53a81

Summary coverage rate:
  lines......: 44.0% (2671 of 6076 lines)
  functions..: 40.9% (978 of 2394 functions)
  branches...: no data found

Files changed coverage rate:
                                                                       |Lines       |Functions  |Branches    
  Filename                                                             |Rate     Num|Rate    Num|Rate     Num
  ===========================================================================================================
  lib/screens/alerts/alert.ex                                          |25.0%    108|31.1%    45|    -      0
  lib/screens/alerts/informed_entity.ex                                | 100%      2| 100%     2|    -      0
  lib/screens/alerts/parser.ex                                         |15.3%     59|66.7%    12|    -      0
  lib/screens/jason_tuple_encoder.ex                                   | 0.0%      1| 0.0%     2|    -      0
  lib/screens/route_patterns/route_pattern.ex                          |35.3%     34|21.4%    14|    -      0
  lib/screens/stops/stop.ex                                            |37.5%     88|53.3%    30|    -      0
  lib/screens/util.ex                                                  |54.8%     73|57.9%    19|    -      0
  lib/screens/v2/candidate_generator/widgets/alerts.ex                 |79.2%     24|50.0%     6|    -      0
  lib/screens/v2/candidate_generator/widgets/reconstructed_alert.ex    |82.1%     95|81.8%    22|    -      0
  lib/screens/v2/disruption_diagram.ex                                 | 100%      1| 100%     1|    -      0
  lib/screens/v2/disruption_diagram/builder.ex                         |95.0%    262|95.7%    47|    -      0
  lib/screens/v2/disruption_diagram/label.ex                           |97.4%     39| 100%     2|    -      0
  lib/screens/v2/disruption_diagram/model.ex                           |92.9%     42|92.3%    13|    -      0
  lib/screens/v2/disruption_diagram/validator.ex                       | 100%     20| 100%     6|    -      0
  lib/screens/v2/localized_alert.ex                                    |82.1%     67|92.3%    13|    -      0
  lib/screens/v2/location_context.ex                                   |66.7%      3|75.0%     4|    -      0
  lib/screens/v2/screen_data.ex                                        |61.2%    134|51.6%    31|    -      0
  lib/screens/v2/widget_instance/alert.ex                              |76.5%     68|92.0%    25|    -      0
  lib/screens/v2/widget_instance/elevator_status.ex                    |89.0%    136|92.7%    41|    -      0
  lib/screens/v2/widget_instance/reconstructed_alert.ex                |88.4%    276| 100%    34|    -      0
  lib/screens/v2/widget_instance/subway_status.ex                      |92.0%    199|95.1%    41|    -      0
  lib/screens_web/views/v2/audio/reconstructed_alert_fullscreen_view.ex| 0.0%     59| 0.0%    11|    -      0
  test/support/disruption_diagram_localized_alert.ex                   |79.1%     43|87.5%     8|    -      0
  test/support/parent_station_id_sigil.ex                              | 100%      3| 100%     1|    -      0
  test/support/subway_tagged_stop_sequences.ex                         |63.2%     19|61.5%    13|    -      0

Download coverage report

@cmaddox5 cmaddox5 changed the base branch from master to prefare-alerts October 27, 2023 13:05
@cmaddox5 cmaddox5 assigned hannahpurcell and unassigned cmaddox5 Oct 31, 2023
@github-actions
Copy link

Coverage of commit 79b4df8

Summary coverage rate:
  lines......: 44.0% (2672 of 6078 lines)
  functions..: 40.9% (979 of 2395 functions)
  branches...: no data found

Files changed coverage rate:
                                                                       |Lines       |Functions  |Branches    
  Filename                                                             |Rate     Num|Rate    Num|Rate     Num
  ===========================================================================================================
  lib/screens/v2/widget_instance/reconstructed_alert.ex                |88.1%    278| 100%    35|    -      0

Download coverage report

Copy link
Contributor

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmaddox5 cmaddox5 merged commit 90bbf8c into prefare-alerts Oct 31, 2023
2 checks passed
@cmaddox5 cmaddox5 deleted the cm/e-branch-headsign-fix branch October 31, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants