You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working on some webpack changes for getting the packaged triptych app compiled down to something the hardware can handle. Will update PR as OFM gives app feedback.
App has been running well on OFM lab screens so this may be the best we can do at the moment. Some key changes:
A new webpack entry has been created for Triptych packaging. This eliminates the need to change webpack when we are packaging up the app. The babel config for the new entry targets the oldest browsers possible (this is done by default when no targets are provided).
All images in Triptych widgets are imported by default so that webpack preloads them in specific folders. We then only zip those folders up in the OFM package. This helps keep package size down.
Any changes made to the existing webpack entry are there to allow backwards compatibility. This should only be a file-loader config for images. I found that if one entry configured file-loader for images, others needed to as well. Regardless, it seemed like a good idea to explicitly configure them.
Summary coverage rate:
lines......: 44.5% (2846 of 6395 lines)
functions..: 42.0% (1019 of 2428 functions)
branches...: no data found
Files changed coverage rate: n/a
Summary coverage rate:
lines......: 44.5% (2846 of 6395 lines)
functions..: 42.0% (1019 of 2428 functions)
branches...: no data found
Files changed coverage rate: n/a
The reason will be displayed to describe this comment to others. Learn more.
The import should only have to be done once in outfront_evergreen_content.tsx. It gives webpack the ability to preload the images and save them to the correct folder. Because this folder only exists in the packaged app, we only need to reference that path on live triptychs. Eventually, DUPs should be treated similarly, but I wanted to leave them alone for now.
Summary coverage rate:
lines......: 44.5% (2846 of 6395 lines)
functions..: 42.0% (1019 of 2428 functions)
branches...: no data found
Files changed coverage rate: n/a
Summary coverage rate:
lines......: 44.5% (2846 of 6395 lines)
functions..: 42.0% (1019 of 2428 functions)
branches...: no data found
Files changed coverage rate: n/a
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: [Timebox] Investigate babel config to possibly transpile from react to plain JS
Working on some webpack changes for getting the packaged triptych app compiled down to something the hardware can handle. Will update PR as OFM gives app feedback.App has been running well on OFM lab screens so this may be the best we can do at the moment. Some key changes:
A new webpack entry has been created for Triptych packaging. This eliminates the need to change webpack when we are packaging up the app. The babel config for the new entry targets the oldest browsers possible (this is done by default when no targets are provided).
All images in Triptych widgets are imported by default so that webpack preloads them in specific folders. We then only zip those folders up in the OFM package. This helps keep package size down.
Any changes made to the existing webpack entry are there to allow backwards compatibility. This should only be a
file-loaderconfig for images. I found that if one entry configuredfile-loaderfor images, others needed to as well. Regardless, it seemed like a good idea to explicitly configure them.Tests added?