Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: departures multi-section auto-sizing #2048

Merged
merged 3 commits into from
May 20, 2024
Merged

Commits on May 16, 2024

  1. refactor: departures widget post-processing

    Pass individual sections to the post-processing function instead of the
    entire list of sections. The only current use of post-processing is in
    the `GlEink` screen type, which only supports one section, so there is
    no requirement to be able to access all sections at once.
    digitalcora committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e0159f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9eeafc3 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. feat: departures multi-section auto-sizing

    * Update departures widget generation to pass layout parameters from
      configuration to the frontend.
    
    * Replace existing auto-sizing implementation, which only worked for a
      single section, with a version that handles multiple sections using
      the layout parameters.
    
    * The auto-sizing itself (independent of the React component) is
      unit-tested. These are the first real frontend tests in Screens, so
      we take the opportunity to:
    
      * Update Jest to its latest version.
    
      * Replace the third-party `@types/jest` package with a direct
        dependency on `@jest/globals`, which is already part of Jest. The
        only advantage of the former is that it allows using `describe`,
        `test`, etc. without importing them.
    
      * Add `eslint-plugin-jest` to our ESLint setup.
    
      * Add `fishery` for defining factories to build test data.
    digitalcora committed May 20, 2024
    Configuration menu
    Copy the full SHA
    683ddd1 View commit details
    Browse the repository at this point in the history