tweak: Suppress Alewife platform closure alert. #2095
Conversation
Coverage of commit
|
| t.location_context.home_stop === "place-gover" | ||
|
|
||
| not suppressed | ||
| t.alert.id not in ["197140", "580015"] |
There was a problem hiding this comment.
Where did these IDs come from? When I try to look up either of them in the API, I get a 404 error. Looking at the alerts currently in the feed, it seems like these should be 571855 and 578253.
There was a problem hiding this comment.
197140 is the alert ID that Dave created in test. I can put the values in variables so that they are more obviously labeled. The other ID is in prod so I'm not sure why the API isn't returning it. I found it on the Future tab in AlertsUI. Based on the discussion in this thread, the alert that will be used for the closure will be a station closure instead of a service change. That may be why 571855 starts and ends at the same time. They are only using it in notifications but will switch to 580015 when the alert is in effect. I will triple check with Dave.
There was a problem hiding this comment.
Huh, okay, I think I see what they're doing there... it doesn't really make sense to me (why two alerts? how is the second one being hidden from the feed?), but the ID is at least correct to what they've told us.
Incidentally, it looks like 571855 is now active currently, until tonight. Maybe we should add that one here in addition to 580015?
There was a problem hiding this comment.
Because 571855 is a Service Change, it won't show on these screens anyway.
Coverage of commit
|
Asana task: ad-hoc
The Alewife platform is being bypassed this weekend. The alert was created using a new Alerts UI feature that the Pre-Fare screens cannot handle yet. We will use a static image in its place.
Note: the scenario we are testing here is suppressing the above alert and letting another shuttle alert render normally. There is a flex zone alert bug keeping this branch from displaying the alert properly. That is being resolved in #2094.