tweak: Prevent delays from serializing diagrams.

[cmaddox5]

Asana task: ad-hoc

When a delay is a single page alert, it will try to serialize the diagram. Problem is that the diagram will always consider delays an invalid effect and spams Splunk with warnings for it. Since we know delays never produce a diagram, we can prevent DisruptionDiagram.serialize(t) from being called at all.

Note: I left validate_effect/1 alone because this code is organized in such a way that other widgets can call it. Didn't want to make a ReconstructedAlert assumption in the module because of that. Feel free to push back on that though.

• Tests added?

[sloanelybutsurely]

sounds good to me. did you want to add a test to this?

[github-actions]

Coverage of commit ff70642

Summary coverage rate:
  lines......: 45.0% (2921 of 6493 lines)
  functions..: 41.0% (1040 of 2535 functions)
  branches...: no data found

Files changed coverage rate:
                                                                          |Lines       |Functions  |Branches    
  Filename                                                                |Rate     Num|Rate    Num|Rate     Num
  ==============================================================================================================
  lib/screens/v2/widget_instance/reconstructed_alert.ex                   |87.1%    341| 100%    46|    -      0

Download coverage report

[cmaddox5]

sounds good to me. did you want to add a test to this?

I think existing tests should cover it. disruption_diagram_test already had a test for delays and assertions for the existing full screen delay tests in reconstructed_alert_test will be the same.