fix: prevent crash on empty list #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors `select_direction_and_route/1` to use pattern mattern more heavily and handle cases when the passed argument is an empty list. This handles the case when the direction and route for the informed entities of an alert are empty or otherwise filtered down to an empty list (e.g. only contain JFK). Additionally this is perhaps slightly more idiomatic Elixir code.
cmaddox5
approved these changes
Jul 18, 2024
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
select_direction_and_route/1to use pattern mattern more heavily and handle cases when the passed argument is an empty list.This handles the case when the direction and route for the informed entities of an alert are empty or otherwise filtered down to an empty list (e.g. only contain JFK). Additionally this is perhaps slightly more idiomatic Elixir code.
Fixes SCREENS-AM