deps: install server_sent_event_stage #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installs server_sent_event_stage which requires also adding `castore`
with explicitly to the `mix.exs` and specifying `override: true`.
server_sent_event_stage expects `{:castore, "~> 0.1"}` but castore
1.0.8 is already installed by another dependency. We can remove the
`override: true` once server_sent_event_stage has been updated to
support newer versions of castore.
The move to from `0.1.x` to `1.0.x` versions in castore was a
non-breaking change[^1]. Subsequent patch versions of castore are simply
updates to the certificates included (removing old/expired certs and
adding new ones).
[^1]: castore 0.1.22..1.0.0: https://diff.hex.pm/diff/castore/0.1.22..1.0.0
Coverage of commit
|
cmaddox5
approved these changes
Jul 31, 2024
|
Since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs server_sent_event_stage which requires also adding
castorewith explicitly to themix.exsand specifyingoverride: true.server_sent_event_stage expects
{:castore, "~> 0.1"}but castore 1.0.8 is already installed by another dependency. We can remove theoverride: trueonce server_sent_event_stage has been updated to support newer versions of castore.The move to from
0.1.xto1.0.xversions in castore was a non-breaking change1. Subsequent patch versions of castore are simply updates to the certificates included (removing old/expired certs and adding new ones).Footnotes
castore 0.1.22..1.0.0: https://diff.hex.pm/diff/castore/0.1.22..1.0.0 ↩