Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to in-memory Alerts cache instead of V3 API #2122

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

sloanelybutsurely
Copy link
Contributor

@sloanelybutsurely sloanelybutsurely commented Aug 1, 2024

Relies on the in-memory Alerts cache when a request for Alerts data has filters supported by the cache. Uses the existing V3 API client otherwise.


@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 388196d to 4100315 Compare August 7, 2024 16:16
Base automatically changed from sloane/push-mzslqxkoqqzx to main August 12, 2024 18:38
@sloanelybutsurely sloanelybutsurely changed the base branch from main to sloane/push-mlqpqmzwwlru August 15, 2024 14:43
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 5abfc19 to 9b10936 Compare August 15, 2024 21:21
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 94ce55d to fda8c66 Compare August 16, 2024 15:30
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 883b9e6 to 3f5ec89 Compare August 16, 2024 20:46
Base automatically changed from sloane/push-mlqpqmzwwlru to main August 16, 2024 20:49
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 4 times, most recently from b387430 to bdd1027 Compare August 19, 2024 17:51
@sloanelybutsurely sloanelybutsurely changed the base branch from main to sloane/push-unnvslkwtssp August 19, 2024 17:51
Base automatically changed from sloane/push-unnvslkwtssp to main August 20, 2024 19:26
Relies on the in-memory Alerts cache when a request for Alerts data has
filters supported by the cache. Uses the existing V3 API client
otherwise.
@sloanelybutsurely sloanelybutsurely requested review from cmaddox5 and a team and removed request for cmaddox5 August 20, 2024 21:09
Copy link
Contributor

@PaulJKim PaulJKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sloanelybutsurely sloanelybutsurely merged commit 6e69fdc into main Aug 21, 2024
11 checks passed
@sloanelybutsurely sloanelybutsurely deleted the sloane/push-lzxxysnqrnoy branch August 21, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants