-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to in-memory Alerts cache instead of V3 API #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 1, 2024 20:07
ac89bd5
to
4685081
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 2, 2024 15:04
4685081
to
c75755a
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mzslqxkoqqzx
branch
2 times, most recently
from
August 2, 2024 15:05
88bc38d
to
2c9a9ff
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 2, 2024 15:05
c75755a
to
8a12984
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mzslqxkoqqzx
branch
from
August 2, 2024 15:11
2c9a9ff
to
9e93440
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 2, 2024 15:11
8a12984
to
247db85
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 2, 2024 18:52
247db85
to
579c240
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mzslqxkoqqzx
branch
from
August 2, 2024 18:52
9e93440
to
4f587ae
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 2, 2024 20:29
579c240
to
27bd32d
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mzslqxkoqqzx
branch
from
August 2, 2024 20:29
4f587ae
to
fbc3f84
Compare
cmaddox5
reviewed
Aug 6, 2024
sloanelybutsurely
force-pushed
the
sloane/push-mzslqxkoqqzx
branch
from
August 7, 2024 13:32
fbc3f84
to
0968bfc
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
2 times, most recently
from
August 7, 2024 16:16
388196d
to
4100315
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mzslqxkoqqzx
branch
from
August 7, 2024 16:16
0968bfc
to
f24f632
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 12, 2024 18:26
4100315
to
325874e
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mzslqxkoqqzx
branch
from
August 12, 2024 18:26
f24f632
to
dc153c2
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 15, 2024 14:43
325874e
to
92af59a
Compare
sloanelybutsurely
changed the base branch from
main
to
sloane/push-mlqpqmzwwlru
August 15, 2024 14:43
sloanelybutsurely
force-pushed
the
sloane/push-mlqpqmzwwlru
branch
from
August 15, 2024 21:21
f780739
to
cbf1d8a
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
2 times, most recently
from
August 15, 2024 21:21
5abfc19
to
9b10936
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
2 times, most recently
from
August 16, 2024 15:30
94ce55d
to
fda8c66
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mlqpqmzwwlru
branch
from
August 16, 2024 15:30
a30b74f
to
b6c369c
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
2 times, most recently
from
August 16, 2024 20:46
883b9e6
to
3f5ec89
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mlqpqmzwwlru
branch
from
August 16, 2024 20:46
503e3a1
to
34b99eb
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 16, 2024 20:48
3f5ec89
to
f949a2e
Compare
sloanelybutsurely
force-pushed
the
sloane/push-mlqpqmzwwlru
branch
from
August 16, 2024 20:48
34b99eb
to
0eace54
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
4 times, most recently
from
August 19, 2024 17:51
b387430
to
bdd1027
Compare
sloanelybutsurely
changed the base branch from
main
to
sloane/push-unnvslkwtssp
August 19, 2024 17:51
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 19, 2024 19:48
bdd1027
to
19dca86
Compare
sloanelybutsurely
force-pushed
the
sloane/push-unnvslkwtssp
branch
from
August 19, 2024 19:48
7de8900
to
45f9f98
Compare
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 20, 2024 19:24
19dca86
to
207cf38
Compare
sloanelybutsurely
force-pushed
the
sloane/push-unnvslkwtssp
branch
from
August 20, 2024 19:24
45f9f98
to
8df9dc9
Compare
Relies on the in-memory Alerts cache when a request for Alerts data has filters supported by the cache. Uses the existing V3 API client otherwise.
sloanelybutsurely
force-pushed
the
sloane/push-lzxxysnqrnoy
branch
from
August 20, 2024 19:27
207cf38
to
e05e823
Compare
sloanelybutsurely
requested review from
cmaddox5 and
a team
and removed request for
cmaddox5
August 20, 2024 21:09
PaulJKim
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
sloanelybutsurely
added a commit
that referenced
this pull request
Aug 23, 2024
sloanelybutsurely
added a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on the in-memory Alerts cache when a request for Alerts data has filters supported by the cache. Uses the existing V3 API client otherwise.